Skip to content

Conversation

@chunqishi
Copy link

Hi, Guillermo.

Thanks a lot for such great package optbinning.
I used it to variable analysis a lot.
One thing is very cool, this lib has great monotonic analysis.

  1. This monotonic trend results are useful.
    please check paper: https://ojs.aaai.org/index.php/AAAI/article/view/7055

  2. This monotonic analysis can used in boost trees by setting monotonic constraints
    see: https://xgboost.readthedocs.io/en/stable/tutorials/monotonic.html
    see: http://scikit-learn.org/stable/auto_examples/ensemble/plot_monotonic_constraints.html
    see: https://catboost.ai/en/docs/references/training-parameters/common#monotone_constraints

Thus: I modified your develop code by 2 parts.

  1. Export the monotonic trend result to binning process summary dataframe.
    monotonic_trend

  2. Add ranking correlation analysis for continuous binning process to double check monotonic trend output.
    monotonic_score

That's all.

Thank you again.

Copy link
Owner

@guillermo-navas-palencia guillermo-navas-palencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I like the idea of showing the monotonic trend in the summary. Regarding the monotonic score using the Kendall tau or Spearman rho correlation, I think we can choose just one and rename it simply as correlation.

@chunqishi
Copy link
Author

Hi, Guillermo.

Done :- )
correlation

Copy link
Owner

@guillermo-navas-palencia guillermo-navas-palencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! Only a minor change and pass flake8.

@chunqishi
Copy link
Author

pull failed?

@guillermo-navas-palencia
Copy link
Owner

Yes, there are two types of problems:

I would only focus on the first one. I will deal with the second type before merging to master.

@bmreiniger
Copy link
Contributor

@chunqishi I think this would be a nice addition, can you resolve the first issue above? If needed perhaps we could help, but the logs of the last run have expired; maybe just push a merge from master to kick off a new check?

@guillermo-navas-palencia guillermo-navas-palencia added the enhancement New feature or request label Jun 6, 2025
@guillermo-navas-palencia guillermo-navas-palencia added this to the v0.21.0 milestone Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants